Propagate headers to WS upstream using connection_init #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chedom Hi, you mentioned that you've also implemented headers propagation at your fork. May I ask you to provide some feedback here, if any? |
|
Is there any update on this being merged? |
|
closed in favor of #425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #290
We already have
http.Headerand include it when hashing.However, we do not propagate the actual value during the init+ack handshake.
With this change, it will send headers as payload.
Works perfectly together with client-facing WS init hook from #275 and makes it possible to propagate init payload from user WS to federation WS. Entities requests also follow and headers are attached to outgoing requests to data sources.
playgroundsends headers as payload instead of regular headers for subscriptions.gqlgenhas a special hook on WebSocket for init.Going to add specific tests, but it is at least backward-compatible with existing suite.